Skip to content

Docs: Split email notifications and webhook notifications into separate howtos #10396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jun 6, 2023

This splits existing howtos into two separate articles:

  • Very little text editing Editing a lot of the texts for clarity and smoothness
  • Added cross-references
  • Updated references
  • Tabbed interface for Discord/Slack payload examples

Refs: #9747


📚 Documentation previews 📚

@benjaoming benjaoming added the Improvement Minor improvement to code label Jun 6, 2023
@benjaoming benjaoming requested a review from a team as a code owner June 6, 2023 18:02
@benjaoming benjaoming requested a review from ericholscher June 6, 2023 18:02
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close with the content updates around email notifications.

@@ -80,7 +61,7 @@ you will see the server response, the webhook request, and the payload.
Activity of a webhook

Custom payload examples
~~~~~~~~~~~~~~~~~~~~~~~
-----------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't change these here. ~~~~ are used as subsections of Build status webhooks and I think it's correct to be subsections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it 👍

But essentially, it's because I wanted to go towards a step-wise how-to (and not nested sections like we have in reference or explanation). Unfortunately, this how-to is very far from such a result :)

In general, how-tos are better like....

Do this
-------

lorem ipsum

Then do this
------------

lorem ipsum

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following two were not updated and they should because of the same reason.

I understand what you want to achieve with the sections, but this case doesn't work like that since they are subsections and not steps the user has to follow.

Build Notifications and Webhooks
================================
Build notifications via webhooks and email
==========================================
Copy link
Contributor Author

@benjaoming benjaoming Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericholscher

re: naming is hard

I changed the feature page to have this title instead. I think it's clearer than the previous one.

I think we should try to use:

  • "Email notifications" when it's the feature in particular and when we want to have a short and sweet name
  • "Build notifications [via webhooks/email]" when we are talking about the value of having instant build feedback more broadly. It's also really good to say "build notifications via webhook" rather than just "webhooks" since the latter can already mean 3 different types of webhooks... incoming (our API), outgoing (GitHub's API) and build notifications (calling other webhooks with payload templates).

Oh yes, and of course we also say "build status webhooks" 🙃 Not on the website, it just says "webhooks" :)

We could remove "build status webhooks" and say "build notifications via webhooks" or "notification webhooks". It's not any big thing, though, anything containing the word "webhook" is bound to be a bit technical :)

How to setup build notifications and webhooks
=============================================
How to setup build status webhooks
==================================
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should be systematic about calling the feature "build status webhooks" since that's how it is right now.

If we're gonna do anything more drastic, I think it should include the Dashboard terminology, so I would just save that for later..

.. note::
Read the Docs can notify external :term:`webhooks <webhook>` when builds are triggered, successful or failed.
In that way,
you can receive build notifications in your own monitoring channels and be alerted you when your builds fail so you can take immediate action.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new

@benjaoming benjaoming requested a review from ericholscher June 7, 2023 12:01
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is closer with a few small cleanup edits.

@benjaoming benjaoming requested a review from ericholscher June 8, 2023 09:31
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@benjaoming benjaoming merged commit e2c3400 into readthedocs:main Jun 9, 2023
@benjaoming benjaoming deleted the docs/split-howto-notifications-webhooks branch June 9, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants