Skip to content

Remove unused permission classes #10373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023
Merged

Remove unused permission classes #10373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions readthedocs/api/v2/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from rest_framework import permissions

from readthedocs.builds.models import Version
from readthedocs.core.permissions import AdminPermission


class IsOwner(permissions.BasePermission):
Expand All @@ -15,29 +14,6 @@ def has_object_permission(self, request, view, obj):
return request.user in obj.users.all()


class CommentModeratorOrReadOnly(permissions.BasePermission):

def has_object_permission(self, request, view, obj):
if request.method in permissions.SAFE_METHODS:
return True # TODO: Similar logic to #1084
return AdminPermission.is_admin(request.user, obj.node.project)


class RelatedProjectIsOwner(permissions.BasePermission):

"""Custom permission to only allow owners of an object to edit it."""

def has_permission(self, request, view):
return (request.method in permissions.SAFE_METHODS)

def has_object_permission(self, request, view, obj):
# Write permissions are only allowed to the owner of the snippet
return (
request.method in permissions.SAFE_METHODS or
(request.user in obj.project.users.all())
)


class APIRestrictedPermission(permissions.BasePermission):

"""
Expand Down