-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Bower: disable strict-ssl
#10370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower: disable strict-ssl
#10370
Conversation
I had to disable strict SSL on Bower due to an error with jQuery: bower/bower#2608 I'm not sure if this is strictly required, but I'm creating a PR in case we need to this in production as well. Related #10356
Oh that seems annoying. Is this only for development and never for production? There's an alternative to switching off SSL here that is popular: bower/bower#2608 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not great, but we don't rebuild these assets often either way.
In theory, we rebuild them on each deploy when preparing the repositories. |
Ah hrm, yeah I forgot that was added to the release script. I guess we can see if it affects next build and can plan from there. I'm not too worried about this fix, and we need to continue building our assets. |
I'm confused now. I just prepare the repositories, but I don't think the |
@humitos I'm guessing that we only do builds with bower manually? In that case, maybe this is fine? Perhaps post a follow-up issue to sort out if this old Node.js stack is staying or being replaced? (assuming that the root of the issue is that most/all of the stack is outdated/deprecated, including some repo and its SSL certificate) |
Yeah, "in theory", I understand the plan here "soonish" is to:
So, I think all the current stack is going to disappear in the medium term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humitos I think that a change like this which makes the build actually work is more desirable than the alternatives.
(I linked to an alternative that was using an unofficial repo which is also not a nice solution).
OK. I'm merging this for now so we unblock the generation of assets. |
I had to disable strict SSL on Bower due to an error with jQuery: bower/bower#2608
I'm not sure if this is strictly required, but I'm creating a PR in case we need to this in production as well.
Related #10356