Email: trust GH and GL emails and mark them as verified #10357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce the amount of emails we send and also provide a better UX to users registering in our platform. Related readthedocs/readthedocs-ops#1269
ericholscher
approved these changes
May 25, 2023
There was a problem hiding this comment.
Looks good. I don't know if we document our email verification at all, so I guess nothing public-facing needs to change.
I have run into a few different people who have had issues with email verification and getting locked out of accounts, so making this easier is a 💯 on my side.
|
He, well, we are saying that we trust them for email verification already: https://docs.readthedocs.io/en/stable/connected-accounts.html#how-does-the-connection-work
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the amount of emails we send and also provide a better UX to users registering in our platform.
Related https://github.com/readthedocs/readthedocs-ops/issues/1269