Version: new field addons
#10337
Merged
Version: new field addons
#10337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `addons` field will be used to tell El Proxito this version was built using `build.commands`. Then, El Proxito will use this field to inject the HTTP header that tells Cloudflare that it should inject the new JS client. This commit is a replacement of #10219 to avoid the time-consuming query that checks the config file of the latest build for the version. Closes #10331
stsewd
reviewed
May 23, 2023
- return only the field we need ("addons")
- only check for `version.addons` if the project doesn't have the feature
|
I'm missing a test here 😄 -- I will add it before merging it. |
stsewd
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
addonsfield will be used to tell El Proxito this version was built usingbuild.commands. Then, El Proxito will use this field to inject the HTTP header that tells Cloudflare that it should inject the new JS client.This commit is a replacement of
#10219 to avoid the time-consuming query that checks the config file of the latest build for the version.
Closes #10331