Skip to content

Version comparing: sort 1.x versions last #10326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2023
Merged

Version comparing: sort 1.x versions last #10326

merged 3 commits into from
May 18, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 18, 2023

Fixes #10046

@stsewd stsewd requested review from a team as code owners May 18, 2023 16:14
@stsewd stsewd requested review from agjohnson and benjaoming May 18, 2023 16:14
benjaoming
benjaoming reviewed May 18, 2023
View reviewed changes
benjaoming
benjaoming approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks for the quick exchange on how to do the string replacement, I think you're right 👍

@stsewd stsewd merged commit 37f9806 into main May 18, 2023
@stsewd stsewd deleted the fix-y.x-comparisson branch May 18, 2023 21:50
@ChampionAsh5357 ChampionAsh5357 mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@benjaoming benjaoming benjaoming approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson was automatically assigned from readthedocs/frontend

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparing a 1.x version results in being lower than 1.1
3 participants
@stsewd @humitos @benjaoming