-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Allow build.commands without build.tools #10281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow build.commands without build.tools #10281
Conversation
It works! But maybe we should add more documentation about the fact that the directory needs to be created? https://docs.readthedocs.io/en/stable/build-customization.html#where-to-put-files |
@humitos I made a "positive" test (manually) to see that a build like this works. But is there something else to be aware of? |
…e used without using `build.os`"
I think adding just one sentence in the link you pasted mentioning this in the documentation is enough. |
When working with the build process, I recommend you to always test locally a bunch of use-cases/branches from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we are close to be able to merge it.
I'll be trying out different branches that look relevant and get back 👍 |
Co-authored-by: Manuel Kaufmann <[email protected]>
Fixes #9280