Proxito: allow overlapping public and external version domains #10260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During development we use overlapping domains: - devthedocs.org - build.devthedocs.org Closes #10241
humitos
approved these changes
Apr 20, 2023
Comment on lines
+458
to
+459
| # Serve from the RTD_EXTERNAL_VERSION_DOMAIN, ensuring it looks like | ||
| # `project--version.RTD_EXTERNAL_VERSION_DOMAIN`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development we use overlapping domains:
Basically now the suspicious hostname checks are done after the public and external version domains have been tried, and before resolving a custom domain.
Closes #10241