Skip to content

Revert "Proxito: inject hosting integration header for build.commands (#10219)" #10259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Revert "Proxito: inject hosting integration header for build.commands (#10219)" #10259

merged 1 commit into from
Apr 19, 2023

Conversation

ericholscher
Copy link
Member

This reverts commit 27215d2.

@ericholscher ericholscher requested a review from a team as a code owner April 19, 2023 13:56
@ericholscher ericholscher requested a review from stsewd April 19, 2023 13:56
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Apr 19, 2023
humitos
humitos approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Note: we are reverting this because it queries builds_build table which takes a lot of time to be done on each request 😢

We still need to find out a way to do this in a more efficient way.

@stsewd stsewd merged commit d4d00af into main Apr 19, 2023
@stsewd stsewd deleted the revert-config branch April 19, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@stsewd stsewd Awaiting requested review from stsewd stsewd is a code owner automatically assigned from readthedocs/backend

Assignees

@ericholscher ericholscher

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @humitos @stsewd