Skip to content

Docs: Update "How to import private repositories" (Diátaxis) #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 25, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Apr 18, 2023

This how-to needs love: https://docs.readthedocs.io/en/stable/guides/importing-private-repositories.html

  • Update warning box
  • Use tabbed interface
  • Make difference between connected accounts with automatic configuration vs. manual configuration clear
  • Add a screenshot to illustrate pages with SSH keys

Refs: #9747

@benjaoming benjaoming added Improvement Minor improvement to code Needed: documentation Documentation is required labels Apr 18, 2023
@benjaoming benjaoming marked this pull request as ready for review April 18, 2023 14:26
@benjaoming benjaoming requested a review from a team as a code owner April 18, 2023 14:26
@benjaoming benjaoming requested a review from ericholscher April 18, 2023 14:26
@benjaoming benjaoming force-pushed the docs/howto-private-repositories branch from 226feb8 to a4369d5 Compare April 20, 2023 19:41
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough 👍

@benjaoming
Copy link
Contributor Author

Had another read-through and didn't spot anything, neither! (it's been over a month, so I can say that I've managed to forget basically everything about writing this)

@benjaoming benjaoming merged commit 08ed9aa into main May 25, 2023
@benjaoming benjaoming deleted the docs/howto-private-repositories branch May 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants