-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Docs: New entries to glossary #10249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benjaoming
merged 15 commits into
readthedocs:main
from
benjaoming:docs/glossary-reproducible
Apr 19, 2023
Merged
Docs: New entries to glossary #10249
benjaoming
merged 15 commits into
readthedocs:main
from
benjaoming:docs/glossary-reproducible
Apr 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
commented
Apr 18, 2023
benjaoming
commented
Apr 18, 2023
…cs/glossary-reproducible
31 tasks
humitos
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I made some suggestions because I think we are going too verbose about the context in some terms but we are not clearly explaining the definition of the term itself.
stsewd
reviewed
Apr 19, 2023
Co-authored-by: Manuel Kaufmann <[email protected]> Co-authored-by: Santos Gallegos <[email protected]>
Co-authored-by: Manuel Kaufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these entries were originally from #10071
Refs: #9747
📚 Documentation previews 📚
docs
): https://docs--10249.org.readthedocs.build/en/10249/dev
): https://dev--10249.org.readthedocs.build/en/10249/