Skip to content

Scripts: Add export statements and instruction to fetch awscli (compile_version_upload_s3.sh) #10245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

Scripts: Add export statements and instruction to fetch awscli (compile_version_upload_s3.sh) #10245

merged 1 commit into from
Apr 17, 2023

Conversation

benjaoming
Copy link
Contributor

Just quickly updating the script...

  1. I received some error "credentials not found" until the environment variables got exported. But otherwise it worked fine 👍

https://github.com/readthedocs/readthedocs.org/blob/main/requirements/pip.in#L37

  1. awscli has been removed from our requirements so needs to be added manually to the environment. Since it's not terribly important, I added a note that we MIGHT use mc (as the docker containers also do) in case there are issues with it.

https://github.com/readthedocs/readthedocs.org/blob/main/requirements/pip.in#L37

@benjaoming benjaoming added the Improvement Minor improvement to code label Apr 17, 2023
@benjaoming benjaoming requested a review from humitos April 17, 2023 12:54
@benjaoming benjaoming requested a review from a team as a code owner April 17, 2023 12:54
@benjaoming
Copy link
Contributor Author

"checks" job went fine (but somehow Circle didn't report it to GH)

"tests" seems to be failing with the recent addition of privacy_level to APIs, but I'm pretty sure that's unrelated 👍

@benjaoming benjaoming merged commit 0c614d1 into readthedocs:main Apr 17, 2023
@benjaoming benjaoming deleted the fix-for-s3-script branch April 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@benjaoming benjaoming

Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaoming @humitos