Skip to content

Docs: Changes to main index page (Diátaxis) #10186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 27, 2023
Merged

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Mar 23, 2023

This PR replaces the currently unmaintained and deviating introduction with one that should:

a) align with the Diatáxis
b) be easier to maintain (compared to the old wall of links)
c) give two types of very very simplified personas a nice experience: new users and existing users
d) work well on mobile views that do NOT show the navigation sidebar (it's hidden in a burger menu)

Reviewers:

  • We decided that we want to work with the content and copy here.
  • It would be nice with suggestions for the texts and which links are important, not to mention priority.
  • I didn't find a way to reuse TOCs or anything of that nature, so I'm pretty sure that there it's not worth trying to become technical here... just accept the potential for content duplication and manual future maintenance and move on :)

Out of scope:

  • Using widgets
  • Auto-generating content, because we have NOT decided how we can encode and reuse meta-data

📚 Documentation previews 📚

@benjaoming benjaoming added Improvement Minor improvement to code Needed: documentation Documentation is required labels Mar 23, 2023
@benjaoming
Copy link
Contributor Author

Status: Still working out the last bits to give a finished impression...

@benjaoming
Copy link
Contributor Author

The PR diff preview certainly is a good use-case for being able to switch it off with toggle button :)

@benjaoming
Copy link
Contributor Author

It seems this might be a bit entangled with #10071

A possible approach is to quickly untangle it, but I wanted to start by pretending that the new sections in #10071 are finished :)

@ericholscher It's very okay if you push changes to this PR 👍 no darlings :)

@benjaoming benjaoming requested a review from ericholscher March 23, 2023 18:37
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 this is way better!

Great PR description 💯.

I pushed a couple commits to add the guide index, but otherwise I think this is a great improvement.

:doc:`/build-notifications` |
:doc:`/user-defined-redirects` |
:doc:`/security-log`
💡 :doc:`Why use a dedicated documentation platform? </integrations>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still pretty odd this is at /integrations, and still kind of talks about webhooks too much? Definitely room for breaking this out into a proper explanation, but not in scope for this PR 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to fix this ASAP. We need a good introduction and overview.

kind of talks about webhooks too much?

That just gave me an idea that we need a graphic instead of a bunch of words there :)

But yeah, #10071 should get us closer


* **Connecting with GitHub, Bitbucket, or GitLab**:
:doc:`Connecting your VCS account </connected-accounts>`
:doc:`🔠 All tutorials </tutorials/index>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked seeing that, too, it felt like it opens an arena for more tutorial content

@benjaoming benjaoming changed the title Docs: Replace "wall of links" with a simpler structure (also text-only) Docs: Changes to main index page (Diátaxis) Mar 27, 2023
@benjaoming benjaoming marked this pull request as ready for review March 27, 2023 10:21
@benjaoming benjaoming requested a review from a team as a code owner March 27, 2023 10:21
@benjaoming
Copy link
Contributor Author

When I had this in draft mode, it was because I thought the text was a rough first-pass. Seems there were some rough edges, so gave it some polishing.

It would be nice with a second pair of eyes on the language, but please feel free to merge after that 👍

@benjaoming benjaoming requested a review from ericholscher March 27, 2023 11:47

You can find out more about our all the :doc:`features </reference/features>` in these pages.
We have a few places for you to get started:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have introduction sentences in a draft but decided to remove them again because the page seemed understandable without them. But I'm happy with both :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's useful as a quick intro 👍

@humitos
Copy link
Member

humitos commented Mar 27, 2023

I took a really quick look a the files changes and this is way better than what we have now. I'm 💯 on merging this and move forward. We can always come back and improve it as we need. This front page is not perfect, of course, but it gives me a lot more condensed information in an easy way that I can quickly parse. I never liked the "wall of links" we had 😄

@ericholscher
Copy link
Member

I agree -- it's a huge improvement. Let's ship it! 🚢

@ericholscher ericholscher merged commit 925d7e7 into main Mar 27, 2023
@ericholscher ericholscher deleted the diataxis/main-index-page branch March 27, 2023 20:47
@benjaoming
Copy link
Contributor Author

Totally agree @humitos - we tried not to get caught it all the possible pit falls of ideas and perfectionism :)

@ericholscher great direct changes 💯 🙏 - I'm gonna take a wild guess here that the PR is OK as it is.

@benjaoming
Copy link
Contributor Author

Oh you merged it exactly when I was gonna do it 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants