Skip to content

Build: fix API call to version.patch() #10175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Build: fix API call to version.patch() #10175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48088f6
Build: fix API call to version.patch()
stsewd Mar 21, 2023
ab71054
Allow null
stsewd Mar 22, 2023
d16be28
Merge branch 'main' into fix-versions-api
stsewd Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/api/v2/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class VersionAdminSerializer(VersionSerializer):

project = ProjectAdminSerializer()
canonical_url = serializers.SerializerMethodField()
build_data = serializers.JSONField(required=False, write_only=True)
build_data = serializers.JSONField(required=False, write_only=True, allow_null=True)

def get_canonical_url(self, obj):
return obj.project.get_docs_url(
Expand Down
1 change: 1 addition & 0 deletions readthedocs/proxito/tests/test_hosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
@override_settings(
PUBLIC_DOMAIN="dev.readthedocs.io",
PUBLIC_DOMAIN_USES_HTTPS=True,
GLOBAL_ANALYTICS_CODE=None,
)
@pytest.mark.proxito
class TestReadTheDocsConfigJson(TestCase):
Expand Down