Lint: one step forward through linting our code #10129
Conversation
|
The only one failing right now is |
There was a problem hiding this comment.
Great initiative to get this done.
This is the kind of PR that can't sit around for long.
I read from top to bottom and couldn't find anything beyond very very trivial.
If someone else can give it a look, they could maybe read from bottom to top so we have tired eyes at opposite ends :)
| @@ -25,7 +23,7 @@ def render(self, data, accepted_media_type=None, renderer_context=None): | |||
| - sort_keys=True on json.dumps | |||
| - use str instead of six.text_types | |||
|
|
|||
| https://github.com/encode/django-rest-framework/blob/master/rest_framework/renderers.py#L89 | |||
| https://github.com/encode/django-rest-framework/blob/b7523f4/rest_framework/renderers.py#L84 | |||
|
I only glanced at this, but I'm happy to see some incremental progress. I'm still a strong +1 on chipping away on linting/formatting until we have the entire repo automatically linted. Being able to rely on
This is an excellent strategy 👍 I feel like we've tried similar in other big refactor/linting PRs. Chunking up review makes it way less intimidating |
I ran
pre-committhrough all the files to see what happened. This is the result after some manual tweaking. Each commit should contain more or less self-contained changes.📚 Documentation previews 📚
docs): https://docs--10129.org.readthedocs.build/en/10129/dev): https://dev--10129.org.readthedocs.build/en/10129/