Build: check for _build/html directory and fail if exists
#10126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
commented
Mar 8, 2023
Comment on lines
55
to
61
| BUILD_OUTPUT_OLD_DIRECTORY_USED = gettext_noop( | ||
| "Your project is outputting files to an old directory ('_build/html') " | ||
| "when building the docs. " | ||
| "Note this directory is not used anymore and the result may be unexpected. " | ||
| "Please, check your build process looking for this directory and replace it by " | ||
| "the path '$READTHEDOCS_OUTPUT/html' instead." | ||
| ) |
There was a problem hiding this comment.
@agjohnson feel free to suggest a better message here.
benjaoming
reviewed
Mar 8, 2023
agjohnson
approved these changes
Mar 8, 2023
Co-authored-by: Anthony <[email protected]>
|
Thanks for your suggestions. Both were better than mine 😅 -- I merged Anthony's one and I'm moving forward with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of a failed build:
Continuation of #10038
Closes #10036