Proxito: actually cache robots.txt and sitemap.xml #10123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to actually inherit from the CDNCacheControlMixin, so caching for these views isn't actually working on .com.
stsewd
commented
Mar 8, 2023
Comment on lines
+1050
to
+1058
| def _get_project(self): | ||
| # Method used by the CDNCacheTagsMixin class. | ||
| return self.request.unresolved_domain.project | ||
|
|
||
| def _get_version(self): | ||
| # Method used by the CDNCacheTagsMixin class. | ||
| # This view isn't explicitly mapped to a version, | ||
| # TODO: refactor how we set cache tags to avoid this. | ||
| return None |
There was a problem hiding this comment.
I'm tracking how to improve this at #10124
There was a problem hiding this comment.
Makes sense to refactor this at some point 👍🏼
humitos
approved these changes
Mar 8, 2023
|
|
||
| # Always cache this view, since it's the same for all users. | ||
| cache_response = True | ||
| project_cache_tag = "robots.txt" |
There was a problem hiding this comment.
It would be good to have a comment explaining why we are defining this here. I assume it's because we need one and only one tag per-project instead of per-version.
Comment on lines
+1050
to
+1058
| def _get_project(self): | ||
| # Method used by the CDNCacheTagsMixin class. | ||
| return self.request.unresolved_domain.project | ||
|
|
||
| def _get_version(self): | ||
| # Method used by the CDNCacheTagsMixin class. | ||
| # This view isn't explicitly mapped to a version, | ||
| # TODO: refactor how we set cache tags to avoid this. | ||
| return None |
There was a problem hiding this comment.
Makes sense to refactor this at some point 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to actually inherit from the CDNCacheControlMixin, so caching for these views isn't actually working on .com.