Skip to content

Fix migration #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix migration #10096

merged 1 commit into from
Mar 1, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 1, 2023

Both migrations are named 0096.

@stsewd stsewd requested a review from a team as a code owner March 1, 2023 22:22
@stsewd stsewd requested a review from benjaoming March 1, 2023 22:22
@stsewd
Copy link
Member Author

stsewd commented Mar 1, 2023

I'm going to just merge this, so tests aren't broken.

@stsewd stsewd merged commit 8ba7a05 into main Mar 1, 2023
@stsewd stsewd deleted the fixmigration branch March 1, 2023 22:38
@benjaoming
Copy link
Contributor

There's another candidate for migration linting! We were talking earlier about trying to avoid adding non-nullable migrations for new fields.

@stsewd
Copy link
Member Author

stsewd commented Mar 1, 2023

There's another candidate for migration linting!

This actually can be fixed by requiring PRs to be updated before merging, this may be a pain when merging consecutive PRs (but I think GH has a feature for this, merge queue or something)

@benjaoming
Copy link
Contributor

This actually can be fixed by requiring PRs to be updated before merging

You might be able to spot the issue then, but there's no guarantee... TBH, I might be inclined to merge the latest main, see that the tests pass and then not notice that there are two 0096_* files :)

@stsewd
Copy link
Member Author

stsewd commented Mar 2, 2023

Tests will error if there are duplicades, we don't need to manually check them

@benjaoming
Copy link
Contributor

In that case, it's all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants