Skip to content

Catch the base OAuth2Error error, not a custom one #10082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

Catch the base OAuth2Error error, not a custom one #10082

merged 2 commits into from
Feb 28, 2023

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 28, 2023 •
edited
Loading

An update to #10022

@ericholscher ericholscher requested a review from a team as a code owner February 28, 2023 17:35
@ericholscher ericholscher requested a review from humitos February 28, 2023 17:39
humitos
humitos reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it's better if we catch the exact exception now we know which one is 😄

@ericholscher ericholscher merged commit 5717bdc into main Feb 28, 2023
@ericholscher ericholscher deleted the fix-grant-error branch February 28, 2023 19:26
@humitos humitos mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@benjaoming benjaoming Awaiting requested review from benjaoming benjaoming is a code owner automatically assigned from readthedocs/backend

Assignees

@ericholscher ericholscher

Labels
None yet
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos