Docs: Add opengraph #10066
Merged
Docs: Add opengraph #10066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericholscher does this need some kind of graphic be made for SOME cards? |
|
Hrm yea, it doesn't like svg's it seems.. |
|
The image will work after merge, because reasons 🙃 |
|
It now also shows the first image as the preview, which is pretty neat! Better than the logo I think. |
|
Yes, having the logo is nice in some cases, but often it makes previews large and a big clumsy. Much better to have an individual image when possible 👍 |
benjaoming
approved these changes
Feb 24, 2023
|
Really liking that we can have some actual SOME previews on documentation 💯 |
|
Yea, I think it'll be nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation previews 📚
docs): https://docs--10066.org.readthedocs.build/en/10066/dev): https://dev--10066.org.readthedocs.build/en/10066/