-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support delisting of projects #10060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support delisting of projects #10060
Conversation
… indexing (robots.txt) and elastic search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! It's pretty close with a couple tweaks, and a test 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty close to me 👍🏼 . Good work!
Co-authored-by: Eric Holscher <[email protected]>
We should definitely get it in next week if we can. Let's drop all the search changes here, and move that discussion here: https://github.com/readthedocs/readthedocs-ext/issues/461#issuecomment-1444063694 |
…list-unofficial-projects
We've resolved issues around ES indexing for now by pushing them to https://github.com/readthedocs/readthedocs-ext/issues/461 There isn't any other outstanding items here, so would be great with a review (and possibly merge) @humitos or @stsewd ? Btw bumped into an interesting use-case today where someone wanted to opt out of in-doc search, but likely not global/dashboard search. We'll probably be back at defining what "delisted" means, and maybe even expose it in the UI - but I think that it's okay to say that "delisted" is currently a general option and everything else will be easy to extend on top of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this because I was hoping to ship it this week 👍
great @ericholscher 👍 I was aiming for someone in an earlier timezone to make it before release :) |
Adds support to delist projects that are unmaintained and unofficial, per policy: https://docs.readthedocs.io/en/stable/unofficial-projects.html
Project.delisted
Fixes https://github.com/readthedocs/meta/issues/99