Skip to content

Docs: Navigation reorder (Diátaxis) #10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Feb 14, 2023

This reorders the navigation, anticipating new top-levels to be created in the next iteration.


📚 Documentation previews 📚

@benjaoming benjaoming added Improvement Minor improvement to code Needed: documentation Documentation is required labels Feb 14, 2023
@benjaoming benjaoming requested review from a team as code owners February 14, 2023 21:31
@benjaoming benjaoming requested a review from agjohnson February 14, 2023 21:31
@benjaoming benjaoming changed the base branch from main to diataxis/main February 14, 2023 21:31
@benjaoming benjaoming removed the request for review from agjohnson February 14, 2023 21:31
@benjaoming
Copy link
Contributor Author

Maybe @humitos has ideas for Tutorial/How-to/Explanation/Reference emojis :)

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable refactor, but still feels like there's some polish needed. This is a good middle step tho.

@ericholscher
Copy link
Member

@benjaoming I'm gonna do a commit on top of this to address a couple ideas.

@ericholscher
Copy link
Member

Alright, I did a bunch of refactoring. I think the real takeaway here is that we don't have much in the way of explanation content written yet. I moved a lot of content out of that section because it didn't really belong there as currently written.

I do worry a bit that we're back in the place of having done a bunch of content improvements here, but have made the docs a bit less usable for normal users by hiding a bunch of content below the top-level TOC. There is always going to be a trade-off though between an overwhelming TOC, and better structure and nesting. I think most people will be finding content via Google though, so I'm not too worried in general, as long as it's possible to find it via navigation.

I think some of the future index page updates will help there, and building out a few other small indexes for each of the sections.

@benjaoming
Copy link
Contributor Author

Alright, I did a bunch of refactoring. I think the real takeaway here is that we don't have much in the way of explanation content written yet. I moved a lot of content out of that section because it didn't really belong there as currently written.

That makes the navigation look better and less overwhelming - which was intended as next steps :)

And it also fills up the Feature Reference to look more complete, which I understand is very important.

But it also moves 10 articles where the content was written as explanation. So that'll leave some refactoring debt.

Examples:

Comment on lines +1 to +2
How to connect your Git repository
==================================
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intended as an explanation since there isn't anything actionable. I can guess at several reasons that a user should read the article, and since some of them are also how-to oriented, I don't see anything bad with the refactor.

We can call it a how-to, that can work as well 👍

Comment on lines +9 to +10
Continuous Documentation Deployment
===================================
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a very big fan of this!

Even shortening it to "Continuous Documentation" can be an interesting way of talking about the workflow and the technical platform at the same time.

@@ -61,6 +61,7 @@
release = version
exclude_patterns = ["_build", "shared", "_includes"]
default_role = "obj"
intersphinx_cache_limit = 14 # cache for 2 weeks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@@ -68,7 +53,23 @@ we've brought most of the most important ones below.
⏩ :doc:`/support`
Read this before asking for help: How to get support and where.

⏩ :doc:`/glossary`
A useful index of terms used in our docs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a wrong location for our Glossary?

Is it because you think the discoverability of the page itself isn't valuable? I tend to agree with that. So kind of 🧹 'ing into this corner seems fine until it has so many terms that it's a real resource.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some other reference index to hide this stuff under, rather than in the top-level nav, is the real answer.

Sharing
=======
Private Documentation Sharing
=============================
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Migrate from rST to MyST <migrate-rest-myst>
enable-offline-formats
Using search analytics <search-analytics>
/automatic-redirects
/science
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha, this page will keep moving around because it's such a hack.

BUT it's noted for later 👍

Copy link
Member

@ericholscher ericholscher Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I mostly just hid it away since it doesn't need to be in the top nav. I think it could live under a top-level Tutorials page like Specific use cases or something?

@@ -198,7 +183,7 @@ out of your documentation and Read the Docs.

* **Advanced project configuration**:
:doc:`subprojects` |
:doc:`Single version docs <single_version>` |
:doc:`Single version docs <single-version>` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirect needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already created.

@benjaoming
Copy link
Contributor Author

Great work! Many great changes! Seems good to go ✔️

I went over all the changes here, noted a few things that might need follow-up and more generally the 10 moved explanation articles.

@benjaoming benjaoming merged commit 602f5de into readthedocs:diataxis/main Feb 15, 2023
@benjaoming benjaoming deleted the diataxis/navigation-reorder branch February 15, 2023 12:04
@ericholscher
Copy link
Member

ericholscher commented Feb 15, 2023

this is not a how-to, it's explanation: https://docs--10026.org.readthedocs.build/en/10026/automatic-redirects.html - I think it should be moved back, but we can invent a format that fits well to cases like this: "Best practices for " or "Steps to make a documentation more "

I would argue it's much closer to a How To than an explanation, given that the primary content is a set of Do's and Dont's? That feels less like explanation and more like "A list of things to do" to me.

This was an explanation: https://docs--10026.org.readthedocs.build/en/10026/canonical-urls.html - the feature reference should also exist, but again we'd need to figure out a good "template" for how we want to represent the a) explanation of a concept and b) the feature.

I'm also not sure this is useful enough to be a top-level explanation? Perhaps we need more nesting for "niche" explanations like this. But I don't see this content as something a normal user needs to care about really at all?

In particular the entire https://docs--10026.org.readthedocs.build/en/10026/canonical-urls.html#how-read-the-docs-generates-canonical-urls section seems like feature content to me?

@benjaoming
Copy link
Contributor Author

I would argue it's much closer to a How To than an explanation, given that the primary content is a set of Do's and Dont's ?

I imagined a refactor where the objective is to avoid mixing how-to and explanation by means of:

  1. Creating a simple and actionable list of do's and don'ts as you mentioned. But the "executive summary"
  2. Keeping the bulk of the current article as the longer explanation, perhaps removing the simplest actionable stuff and referring to the "How-to: Best practices for SEO"-ish article

@benjaoming
Copy link
Contributor Author

I'm also not sure this is useful enough to be a top-level explanation?

Definitely agreeing that it's not a very important article to figure as a top-level. I think you did a wonderful work on getting the current navigation to be very beautiful and easy to read.

I had an intention to be more pragmatic to accept more overwhelming amounts of items in Explanation because of the next steps to add new sub-levels in Explanation and How-to.

@ericholscher
Copy link
Member

I didn't really make it less overwhelming as a goal, I just removed the things that didn't make sense at the top-level, because I think that's the best trade-off. We want the top-level nav to have the high-value things, and other stuff to be findable with indexes and search.

@humitos
Copy link
Member

humitos commented Feb 16, 2023

Maybe @humitos has ideas for Tutorial/How-to/Explanation/Reference emojis :)

I'd put the emojis at the beginning of the sentence so they are all aligned:

Screenshot_2023-02-16_08-07-35

Also, I would not use emojis on the inner links because it make them more prominent and differentiate over the others. In particular, "Developer Documentation", is the least important one but it's the most prominent in that section now because of the emoji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants