APIv2: better build command sanitization #10025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This made the regex to not match properly.
stsewd
approved these changes
Feb 14, 2023
humitos
changed the title
\
|
I updated this PR to add a test case and also to solve the problem we had when returning the commands from the cold storage. |
stsewd
reviewed
Feb 15, 2023
stsewd
approved these changes
Feb 15, 2023
|
FWIW, I had a user who was confused about whether the conda env was being used, and the path to $CONDA_ENV was actually useful for them. Not a super important use case, but definitely something that could be notable. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/for Conda because it wasn't matching properly.sanitize_build_command