Skip to content

Docs: Navigation menu wrap-up: About, Features and Advanced Features as Reference (Diátaxis) #10010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Feb 9, 2023

This collects existing articles in the same menus with a bit of consideration of ordering of menu items, but otherwise not much more to it.

Notice that Read the Docs for Business is moved in #10007

Refs: #9746


📚 Documentation previews 📚

@benjaoming benjaoming added Improvement Minor improvement to code Needed: documentation Documentation is required labels Feb 9, 2023
@benjaoming benjaoming requested review from a team as code owners February 9, 2023 19:37
@benjaoming benjaoming changed the base branch from main to diataxis/main February 9, 2023 19:37
@@ -88,4 +88,4 @@ Our bootstrapped company is owned and controlled by the founders,
and fully funded by our customers and advertisers.
That allows us to focus 100% of our attention on building the best possible product for you.

Learn more :doc:`/about`.
Learn more :doc:`/about/index`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a directory here.

It's not immediately in use. But the intention was to have an actual collection of articles, spanning some existing items once that we start doing path refactors and redirects (which we have said not to do right now)

Because of DirHTML, this shouldn't make a difference right now.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me to get the menu into shape for the big main merge.

@@ -108,11 +108,14 @@ to help you create fantastic documentation for your project.
:caption: Reference
:glob:

/reference/features
Copy link
Member

@ericholscher ericholscher Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

I think this page is what should replace https://docs.readthedocs.io/en/stable/hosting.html -- a really nice feature index with highlights of each feature.

Similar to our landing pages, a feature highlight, that drops into that feature detail... 🤔
Screenshot 2023-02-09 at 4 27 09 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when we introduced it, we said to start using it as the new index -- but we just postponed the design of the index for next iteration :)

I think the work to move the hosting features in as a description list is great, we can probably do that for other pages, too. But it's best to do in just one PR, otherwise we get Git conflicts galore :)

.. toctree::
:maxdepth: 1
:hidden:
:caption: Features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@agjohnson
Copy link
Contributor

I noticed this on a few PRs that I've been pinged on, but the TOC menu seems out of order or like another level of hierarchy is needed or something:

image

"Explanations" have grown to dominate the TOC, and seem like less likely targets than the docs hidden beneath the fold on the menu. The long doc names also contribute here of course.

I haven't been following specifics of PRs here, so perhaps this was discussed, but is there plans to nest or reorder the TOC items under explanation?

@benjaoming
Copy link
Contributor Author

@agjohnson there's a planning document about introducing a new TOC structure in the next iteration: https://docs.google.com/document/d/1LQXMUOAKBZ4RhAew2F4TCDp-QW7czH5Dq6BPxlyA_dw/edit#

In this document, we went over the first proposals of new sub-levels of Explanation and How-to, and we went far enough to get a good feeling... the remaning part will happen in PRs. As we all know, the hardest problem in computer science is "naming things" :)

@benjaoming
Copy link
Contributor Author

@ericholscher I managed to quickly "dump" a list of contents in the about section, it needs a little extra love. But aside from that, the PR seems ready. You're welcome to make any changes necessary to merge it, otherwise I'll return to it on Tuesday ⏳

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty much ready.

@benjaoming benjaoming merged commit 7634960 into readthedocs:diataxis/main Feb 14, 2023
@benjaoming benjaoming deleted the diataxis/about-navigation-refactor branch February 14, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants