Skip to content

Celery: cleanup pidbox keys #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Celery: cleanup pidbox keys #10002

merged 2 commits into from
Feb 13, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 8, 2023

Simple task to remove pidbox keys older than 15 minutes. This is a workaround to avoid Redis OOM for now.

We will need to find out a better solution here. There is an upstream issue opened that we should check in the near future and probably remove this
workaround: celery/celery#6089

Related: https://github.com/readthedocs/readthedocs-ops/issues/1260

@humitos humitos requested a review from a team as a code owner February 8, 2023 09:36
@humitos humitos requested a review from stsewd February 8, 2023 09:36
Simple task to remove `pidbox` keys older than 15 minutes.
This is a workaround to avoid Redis OOM for now.

We will need to find out a better solution here. There is an upstream issue
opened that we should check in the near future and probably remove this
workaround: celery/celery#6089
@humitos humitos force-pushed the humitos/cleanup-pidbox-objects branch from 28f1128 to b97f825 Compare February 8, 2023 09:41
@humitos humitos requested a review from ericholscher February 9, 2023 15:51
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a better fix than my tmux session :D

`app.backend.client` is not working anymore since we are not using a backend
result anymore.
@humitos humitos enabled auto-merge (squash) February 13, 2023 10:11
@humitos humitos merged commit b4709dc into main Feb 13, 2023
@humitos humitos deleted the humitos/cleanup-pidbox-objects branch February 13, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants