Skip to content

Django: adapt admin code for 3.x #9356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Jun 20, 2022 · 0 comments · Fixed by #10668
Closed

Django: adapt admin code for 3.x #9356

humitos opened this issue Jun 20, 2022 · 0 comments · Fixed by #10668
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Jun 20, 2022

It seems that we missed an upgrade to make it fully compatible with Django 3.x

We are using admin.ACTION_CHECKBOX_NAME when it was deprecated and it was removed already:

The compatibility import of django.contrib.admin.helpers.ACTION_CHECKBOX_NAME in django.contrib.admin is removed.

(from https://docs.djangoproject.com/en/4.0/releases/3.1/#id1)

The code lives at

readthedocs.org/readthedocs/notifications/views.py

Line 48 in e94c260

admin.ACTION_CHECKBOX_NAME,

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Jun 20, 2022
@humitos humitos mentioned this issue Aug 26, 2023
Merged
humitos added a commit that referenced this issue Aug 26, 2023
@humitos
Django 3.x upgrade
faf78bc 
Closes #9356
humitos added a commit that referenced this issue Aug 28, 2023
@humitos
Django 3.x upgrade (#10668)
74aed03 
Closes #9356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Django 3.x upgrade readthedocs/readthedocs.org
1 participant
@humitos