Out of sync remote repositories when they are trasfered from another organization #8715
Comments
stsewd
added a commit
that referenced
this issue
May 10, 2022
…ser. We were doing some checks to avoid removing the remote organization from a remote repo when this is listed from the /users/repos/ endpoint or changing the organization when the project was moved. But, since we are hitting the GitHub API directly, we can always trust the result from there, which includes the type of owner of the repository, we can use that to decide if the repository belongs to an organization or not. Fixes #8715
stsewd
added a commit
that referenced
this issue
May 10, 2022
…ser. We were doing some checks to avoid removing the remote organization from a remote repo when this is listed from the /users/repos/ endpoint or changing the organization when the project was moved. But, since we are hitting the GitHub API directly, we can always trust the result from there, which includes the type of owner of the repository, we can use that to decide if the repository belongs to an organization or not. Fixes #8715
stsewd
added a commit
that referenced
this issue
May 10, 2022
…ser. We were doing some checks to avoid removing the remote organization from a remote repo when this is listed from the /users/repos/ endpoint or changing the organization when the project was moved. But, since we are hitting the GitHub API directly, we can always trust the result from there, which includes the type of owner of the repository, we can use that to decide if the repository belongs to an organization or not. Fixes #8715
Repository owner
moved this from Needs review
to Done
in 📍Roadmap
May 31, 2022
stsewd
added a commit
that referenced
this issue
May 31, 2022
…sers (#9178) We were doing some checks to avoid removing the remote organization from a remote repo when this is listed from the /users/repos/ endpoint or changing the organization when the project was moved. But, since we are hitting the GitHub API directly, we can always trust the result from there, which includes the type of owner of the repository, we can use that to decide if the repository belongs to an organization or not. Fixes #8715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like on github, when a repo is transferred from another organization, they keep the same ID, and in our code these repositories will still be attached to the old organization. They are never updated, because they hit this
readthedocs.org/readthedocs/oauth/services/github.py
Lines 120 to 125 in 61e94ca
(their current organization doesn't match the one they say to be coming from)
We need to improve that check to look for cases like this.
The text was updated successfully, but these errors were encountered: