Skip to content

config file ignored #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaborbernat opened this issue Feb 16, 2021 · 4 comments
Closed

config file ignored #7915

gaborbernat opened this issue Feb 16, 2021 · 4 comments
Labels
Support Support question

Comments

@gaborbernat
Copy link
Contributor

Hello,

I added a readthedocs config to my project tox-dev/tox@d5957b8. However, for some reason, it seems to be ignored and 3.6 still used instead of python3.8. Any ideas? (build number 13028284)

Thanks,
@stsewd
Copy link
Member

stsewd commented Feb 16, 2021

Thanks for reporting, I can't replicate this locally, so I'll need to dig a little more :/

@stsewd
Copy link
Member

stsewd commented Feb 16, 2021

And.... This is why, you have two config files https://github.com/tox-dev/tox/blob/master/readthedocs.yml, the older one is being read first :D

@stsewd
Copy link
Member

stsewd commented Feb 16, 2021

You should delete the older one, so the new one always takes effect. I think we should reduce the number of accepted formats to avoid this problems.

@stsewd stsewd closed this as completed Feb 16, 2021
@stsewd stsewd added the Support Support question label Feb 16, 2021
stsewd added a commit that referenced this issue Feb 16, 2021
@stsewd
Use only one variant of the config file
e773701 
Why `.readthedocs.yaml`?

- Configuration files usually start with a `.` so they are hidden in
  unix like systems.
- `.yaml` is the official and recommended extension for yaml files.

We could go a little further and use a feature flag to stop finding
the other ones.

ref #7915
@stsewd stsewd mentioned this issue Feb 16, 2021
Merged
stsewd added a commit that referenced this issue Feb 16, 2021
@stsewd
Use only one variant of the config file (#7918)
61738e1 
Why `.readthedocs.yaml`?

- Configuration files usually start with a `.` so they are hidden in
  unix like systems.
- `.yaml` is the official and recommended extension for yaml files.

We could go a little further and use a feature flag to stop finding
the other ones.

ref #7915
@gaborbernat
Copy link
Contributor Author

Thanks, all done 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Support Support question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaborbernat @stsewd