Skip to content

Remove message about contacting support after the feature is enabled #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Nov 23, 2020 · 0 comments · Fixed by #7715
Closed

Remove message about contacting support after the feature is enabled #7689

humitos opened this issue Nov 23, 2020 · 0 comments · Fixed by #7715
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Nov 23, 2020

Once the feature STORE_PAGEVIEWS is enabled in a project, we still show the message: "This beta feature can be enabled by asking support". Some users found this confusing and thought the feature wasn't fully enabled or it was mis-configured.

readthedocs.org/readthedocs/templates/projects/project_traffic_analytics.html

Line 16 in b274de7

This beta feature can be enabled by <a href="mailto:{{ SUPPORT_EMAIL }}">asking support</a>.

We may want to check if the feature is enabled and remove that message for those projects.
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Nov 23, 2020
@stsewd stsewd added the Good First Issue Good for new contributors label Nov 23, 2020
@stsewd stsewd mentioned this issue Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extra features: allow to display them conditionally readthedocs/readthedocs.org
2 participants
@humitos @stsewd