Tests: mock trigger build to speed up tests

Otherwise trigger_build would try to call the API,
and then keep trying till it times out.

In these tests we don't need to run trigger_build.

Author: stsewd

readthedocs/rtd_tests/tests/test_automation_rules.py

@@ -20,6 +20,7 @@
 
 
 @pytest.mark.django_db
+@mock.patch('readthedocs.builds.automation_actions.trigger_build')
 class TestRegexAutomationRules:
 
     @pytest.fixture(autouse=True)
@@ -74,7 +75,8 @@ def setup_method(self):
     )
     @pytest.mark.parametrize('version_type', [BRANCH, TAG])
     def test_match(
-            self, version_name, regex, result, version_type):
+        self, trigger_build, version_name, regex, result, version_type,
+    ):
         version = get(
             Version,
             verbose_name=version_name,
@@ -108,7 +110,7 @@ def test_match(
         ]
     )
     @pytest.mark.parametrize('version_type', [BRANCH, TAG])
-    def test_predefined_match_all_versions(self, version_name, result, version_type):
+    def test_predefined_match_all_versions(self, trigger_build, version_name, result, version_type):
         version = get(
             Version,
             verbose_name=version_name,
@@ -144,7 +146,7 @@ def test_predefined_match_all_versions(self, version_name, result, version_type)
         ]
     )
     @pytest.mark.parametrize('version_type', [BRANCH, TAG])
-    def test_predefined_match_semver_versions(self, version_name, result, version_type):
+    def test_predefined_match_semver_versions(self, trigger_build, version_name, result, version_type):
         version = get(
             Version,
             verbose_name=version_name,
@@ -163,7 +165,6 @@ def test_predefined_match_semver_versions(self, version_name, result, version_ty
         )
         assert rule.run(version) is result
 
-    @mock.patch('readthedocs.builds.automation_actions.trigger_build')
     def test_action_activation(self, trigger_build):
         version = get(
             Version,
@@ -185,7 +186,7 @@ def test_action_activation(self, trigger_build):
         trigger_build.assert_called_once()
 
     @pytest.mark.parametrize('version_type', [BRANCH, TAG])
-    def test_action_delete_version(self, version_type):
+    def test_action_delete_version(self, trigger_build, version_type):
         slug = 'delete-me'
         version = get(
             Version,
@@ -207,7 +208,7 @@ def test_action_delete_version(self, version_type):
         assert not self.project.versions.filter(slug=slug).exists()
 
     @pytest.mark.parametrize('version_type', [BRANCH, TAG])
-    def test_action_delete_version_on_default_version(self, version_type):
+    def test_action_delete_version_on_default_version(self, trigger_build, version_type):
         slug = 'delete-me'
         version = get(
             Version,
@@ -231,7 +232,7 @@ def test_action_delete_version_on_default_version(self, version_type):
         assert rule.run(version) is True
         assert self.project.versions.filter(slug=slug).exists()
 
-    def test_action_set_default_version(self):
+    def test_action_set_default_version(self, trigger_build):
         version = get(
             Version,
             verbose_name='v2',
@@ -251,7 +252,6 @@ def test_action_set_default_version(self):
         assert rule.run(version) is True
         assert self.project.get_default_version() == version.slug
 
-    @mock.patch('readthedocs.builds.automation_actions.trigger_build')
     def test_version_hide_action(self, trigger_build):
         version = get(
             Version,
@@ -274,7 +274,6 @@ def test_version_hide_action(self, trigger_build):
         assert version.hidden is True
         trigger_build.assert_called_once()
 
-    @mock.patch('readthedocs.builds.automation_actions.trigger_build')
     def test_version_make_public_action(self, trigger_build):
         version = get(
             Version,
@@ -297,7 +296,6 @@ def test_version_make_public_action(self, trigger_build):
         assert version.privacy_level == PUBLIC
         trigger_build.assert_not_called()
 
-    @mock.patch('readthedocs.builds.automation_actions.trigger_build')
     def test_version_make_private_action(self, trigger_build):
         version = get(
             Version,

readthedocs/rtd_tests/tests/test_project_views.py

@@ -9,7 +9,7 @@
 from django.utils import timezone
 from django.views.generic.base import ContextMixin
 from django_dynamic_fixture import get, new
-from unittest.mock import patch
+from unittest import mock
 
 from readthedocs.builds.constants import EXTERNAL
 from readthedocs.builds.models import Build, Version
@@ -28,7 +28,7 @@
 )
 
 
-@patch('readthedocs.projects.views.private.trigger_build', lambda x: None)
+@mock.patch('readthedocs.core.utils.trigger_build', mock.MagicMock())
 class TestProfileMiddleware(RequestFactoryTestMixin, TestCase):
 
     wizard_class_slug = 'import_wizard_view'
@@ -62,7 +62,7 @@ def test_profile_middleware_no_profile(self):
         self.assertEqual(resp.status_code, 302)
         self.assertEqual(resp['location'], '/projects/foobar/')
 
-    @patch('readthedocs.projects.views.private.ProjectBasicsForm.clean')
+    @mock.patch('readthedocs.projects.views.private.ProjectBasicsForm.clean')
     def test_profile_middleware_spam(self, form):
         """User will be banned."""
         form.side_effect = ProjectSpamError
@@ -85,6 +85,7 @@ def test_profile_middleware_banned(self):
         self.assertEqual(resp['location'], '/')
 
 
+@mock.patch('readthedocs.core.utils.trigger_build', mock.MagicMock())
 class TestBasicsForm(WizardTestCase):
 
     wizard_class_slug = 'import_wizard_view'
@@ -167,6 +168,7 @@ def test_form_missing(self):
         self.assertWizardFailure(resp, 'repo_type')
 
 
+@mock.patch('readthedocs.core.utils.trigger_build', mock.MagicMock())
 class TestAdvancedForm(TestBasicsForm):
 
     def setUp(self):
@@ -227,7 +229,7 @@ def test_remote_repository_is_added(self):
         self.assertIsNotNone(proj)
         self.assertEqual(proj.remote_repository, remote_repo)
 
-    @patch(
+    @mock.patch(
         'readthedocs.projects.views.private.ProjectExtraForm.clean_description',
         create=True,
     )
@@ -251,7 +253,7 @@ def test_form_spam(self, mocked_validator):
             proj = Project.objects.get(name='foobar')
         self.assertFalse(self.user.profile.banned)
 
-    @patch(
+    @mock.patch(
         'readthedocs.projects.views.private.ProjectExtraForm.clean_description',
         create=True,
     )
@@ -451,7 +453,7 @@ def test_delete_project(self):
 
         # Mocked like this because the function is imported inside a class method
         # https://stackoverflow.com/a/22201798
-        with patch('readthedocs.projects.tasks.clean_project_resources') as clean_project_resources:
+        with mock.patch('readthedocs.projects.tasks.clean_project_resources') as clean_project_resources:
             response = self.client.post('/dashboard/pip/delete/')
             self.assertEqual(response.status_code, 302)
             self.assertFalse(Project.objects.filter(slug='pip').exists())
@@ -477,7 +479,7 @@ def test_delete_superproject(self):
             html=True,
         )
 
-    @patch('readthedocs.projects.views.private.attach_webhook')
+    @mock.patch('readthedocs.projects.views.private.attach_webhook')
     def test_integration_create(self, attach_webhook):
         project = get(Project, slug='pip', users=[self.user])
 
@@ -498,7 +500,7 @@ def test_integration_create(self, attach_webhook):
             integration=integration.first()
         )
 
-    @patch('readthedocs.projects.views.private.attach_webhook')
+    @mock.patch('readthedocs.projects.views.private.attach_webhook')
     def test_integration_create_generic_webhook(self, attach_webhook):
         project = get(Project, slug='pip', users=[self.user])
 

readthedocs/rtd_tests/tests/test_sync_versions.py

@@ -13,6 +13,7 @@
 from readthedocs.projects.models import Project
 
 
+@mock.patch('readthedocs.core.utils.trigger_build', mock.MagicMock())
 class TestSyncVersions(TestCase):
     fixtures = ['eric', 'test_data']
 
@@ -902,6 +903,7 @@ def test_automation_rule_dont_delete_default_version(self):
         )
         self.assertTrue(self.pip.versions.filter(slug=version_slug).exists())
 
+@mock.patch('readthedocs.core.utils.trigger_build', mock.MagicMock())
 class TestStableVersion(TestCase):
     fixtures = ['eric', 'test_data']
 
@@ -1396,6 +1398,7 @@ def test_user_defined_stable_version_branch_with_tags(self):
         self.assertFalse(other_stable.exists())
 
 
+@mock.patch('readthedocs.core.utils.trigger_build', mock.MagicMock())
 class TestLatestVersion(TestCase):
     fixtures = ['eric', 'test_data']