-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Increase build timeout limit for Koalas project #6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To speed up, I had to disable PDF build and EPUB build; however, we still intermittently face this timeout (which spams emails .. :( .. ). Can I ask to increase the timeout? |
Hi @HyukjinKwon! I just took a look at your builds and I found that that all the builds were executed on one the same server (build04). We are having an issue with this server (it's executing too many builds at the same time) that we hopefully fix soon. |
Thanks! I am actively working on that project. I will update if I happen to find out this issue isn't persistent anymore! |
The project is failing for another reason now
The project doesn't have build04 as builder anymore. |
It suddenly fails there. I'll check and update within few days. |
Hi, the error was temporary. The problematic package started to install properly. https://readthedocs.org/projects/koalas/builds/9773902/ |
Hi, I still face time out intermittently. Can I ask to increase time out please? I am handling flakiness of |
Hi @HyukjinKwon! I increased time and memory for your project. I'm closing this issue. Feel free to re-open if you think it's needed. Also, let me know if it's building properly :) |
Thank you so much guys! |
Eh, sorry @humitos can you double check if the time is increased? |
Last builds are passing now |
Thanks for checking it closely @stsewd BTW, did the build in Read the docs decrease timeout lately? Seems the builds started to fail again: |
No, we haven't. But looks like the conda step is taking a lot of the time Do you need both channels? Conda gets slower depending on the number of channels. Also, if you agree, we can try using the last version of conda for your project (there are some improvements to make it fast) https://docs.readthedocs.io/en/stable/guides/feature-flags.html#available-flags |
Let me give a shot to don't use both channels (opened a PR databricks/koalas#932). I will update you by EOD of tomorrow. I will try However, I was wondering why it suddenly times out at 600 seconds instead of 900 seconds, which was used to be. |
Probably a bug in our code, sometimes if the command fails the command doesn't get updated on the db #4288 |
Thanks, @stsewd, I will wait for the fix and follow what you guided first, and see what happens. |
This PR targets to deal with readthedocs/readthedocs.org#6254 (comment)
I have enabled the flag, but it stills times out. I'm increasing the build time to 15 min |
Looks like is passing again, let me know if it keeps timing out |
Awesome! |
For a bit of background: Currently documentation generation is being failed in Read the Docs due to timeout. The largest portion of time is being consumed for Conda installation, and seems like Read the Docs maintainers also encourage people to just use PIP instead (see also `https://github.com/readthedocs/readthedocs.org/issues/6254#issuecomment-542288316`). We use Conda installation in order to install JDK 8 because Read the Docs has JDK 11 by default, and Spark 2.x does not support JDK 11. For what this PR proposes: This PR switches Conda to PIP to install Java 8 via using `install-jdk` package. Seems like they use AdoptOpenJDK instead but the jobs looks passing see https://readthedocs.org/projects/koalas/builds/10741596/. Once Spark 3.0 is released, we can remove all related codes as Spark 3.0 supports JDK 11, and we don't need to install JDK 8 manually. This PR decreases build time 1000 seconds (timeout) to around 900 seconds.
This PR targets to deal with readthedocs/readthedocs.org#6254 (comment)
For a bit of background: Currently documentation generation is being failed in Read the Docs due to timeout. The largest portion of time is being consumed for Conda installation, and seems like Read the Docs maintainers also encourage people to just use PIP instead (see also `https://github.com/readthedocs/readthedocs.org/issues/6254#issuecomment-542288316`). We use Conda installation in order to install JDK 8 because Read the Docs has JDK 11 by default, and Spark 2.x does not support JDK 11. For what this PR proposes: This PR switches Conda to PIP to install Java 8 via using `install-jdk` package. Seems like they use AdoptOpenJDK instead but the jobs looks passing see https://readthedocs.org/projects/koalas/builds/10741596/. Once Spark 3.0 is released, we can remove all related codes as Spark 3.0 supports JDK 11, and we don't need to install JDK 8 manually. This PR decreases build time 1000 seconds (timeout) to around 900 seconds.
Details
Expected Result
Build pass without timeout
Actual Result
Build timeout
The text was updated successfully, but these errors were encountered: