-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove django-guardian db #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @stsewd, Can I do take this? |
Sure! You should run the migrations after #5863 was merged to see what can be removed (or take a look at https://github.com/django-guardian/django-guardian/tree/devel/guardian/migrations), and make a migration removing those models. |
So, we have two ways to remove the migration. We actually needed to execute the first one before the deploy :/ The first one removes all the migrations from the db, and the second one is the sql to execute directly on the db (in case we can't do 1). All this commands should be run from the commit c907f03 (just before the one that removes the app)
|
@stsewd Do you wanna let me finish the issue or you wanna take that on your head? |
@tapaswenipathak this now needs a design decision. We need to execute the SQL or the command in the production server. |
Ran into an issue running the backwards migration in prod. Going to have to hand-run the SQL. |
This was fixed, we executed the drop sql in the db |
Django guardian was removed #5863, but we still have the tables on the db. Probably we want to do this after the deploy and when we are sure that nothing is broken.
https://django-guardian.readthedocs.io/en/stable/api/guardian.models.html#std:model-UserObjectPermission
The text was updated successfully, but these errors were encountered: