Skip to content

Profile page performance issue #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidfischer opened this issue Mar 15, 2019 · 3 comments · Fixed by #5472
Closed

Profile page performance issue #5468

davidfischer opened this issue Mar 15, 2019 · 3 comments · Fixed by #5472
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@davidfischer
Copy link
Contributor

While working on #5464, I discovered a performance issue on the profile page.

There appears to be a couple duplicated queries in the profile screen. One is to get maintainers for a project and another is to get the latest build. This results in O(n) SQL queries where n is the number of projects displayed. It should be possible to get this data using an annotation.

Parts of this look similar to #5467 and #5465.

There is also one query per project to generate the "view docs" link but that will probably involve refactoring the resolver. You might want to hold off on that as that is not a good first issue. See #3712.

Screen Shot 2019-03-15 at 11 24 33 AM

@davidfischer davidfischer added Good First Issue Good for new contributors Improvement Minor improvement to code labels Mar 15, 2019
@saadmk11
Copy link
Member

@davidfischer should these issues be worked on after merging #5464 or should i install debug toolbar locally and try to resolve them?

@davidfischer
Copy link
Contributor Author

#5464 will help you work on them but it isn't necessary to fix them.

@stale
Copy link

stale bot commented Apr 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Apr 29, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants