Skip to content

Build List Screen Performance Issue #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidfischer opened this issue Mar 15, 2019 · 1 comment · Fixed by #5470
Closed

Build List Screen Performance Issue #5467

davidfischer opened this issue Mar 15, 2019 · 1 comment · Fixed by #5470
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@davidfischer
Copy link
Contributor

While working on #5464, I discovered a performance issue on the build list screen.

There appears to be a couple duplicated queries in the build list screen. One is to get the project (probably from Build.get_absolute_url) for the build and the other gets the version (probably from build_list_detailed.html). This results in O(n) SQL queries where n is the number of builds displayed. It should be possible to get the project and version for each build using select_related.

Screen Shot 2019-03-15 at 11 00 13 AM
@davidfischer davidfischer added Good First Issue Good for new contributors Improvement Minor improvement to code labels Mar 15, 2019
@saadmk11
Copy link
Member

Working on it!

@davidfischer davidfischer mentioned this issue Mar 15, 2019
Closed
@saadmk11 saadmk11 mentioned this issue Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build List Screen Performance Issue Fix. saadmk11/readthedocs.org
2 participants
@davidfischer @saadmk11