Skip to content

Artifacts aren't cleaned when changing from Sphinx to Mkdocs #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raoshridhar90 opened this issue Oct 16, 2018 · 23 comments
Closed

Artifacts aren't cleaned when changing from Sphinx to Mkdocs #4764

raoshridhar90 opened this issue Oct 16, 2018 · 23 comments
Labels
Bug A bug Priority: low Low priority

Comments

@raoshridhar90
Copy link

Details

Expected Result

HTML copy of what I see on View Docs

Actual Result

HTML copy is of Sphinx document I was trying out
what i see
what i get

P.S: I am absolutely brand new at this because I know nothing about Python. I'm just a technical writer trying to find a way to document my company's backend.

@stsewd stsewd added Support Support question Needed: more information A reply from issue author is required labels Oct 16, 2018
@stsewd
Copy link
Member

stsewd commented Oct 16, 2018

HTML copy of what I see on View Docs

Sorry, I don't understand your issue, can you please clarify a little more?

We have this getting started guides for sphinx or mkdocs here https://docs.readthedocs.io/en/latest/intro/getting-started-with-sphinx.html https://docs.readthedocs.io/en/latest/intro/getting-started-with-mkdocs.html

@davidfischer
Copy link
Contributor

I'm pretty certain this issue is because the documentation type is set to Sphinx instead of MkDocs. In the settings for your project, you need to change the documentation type.

screen shot 2018-10-16 at 11 23 26 am

@raoshridhar90
Copy link
Author

raoshridhar90 commented Oct 17, 2018

HTML copy of what I see on View Docs

Sorry, I don't understand your issue, can you please clarify a little more?

We have this getting started guides for sphinx or mkdocs here https://docs.readthedocs.io/en/latest/intro/getting-started-with-sphinx.html https://docs.readthedocs.io/en/latest/intro/getting-started-with-mkdocs.html

Hey @stsewd, I would be happy to do so.

What I meant (and should have been clear about) is that ReadTheDocs is building the document, and I can see Markdown that I changed and uploaded on to GitHub and imported onto ReadTheDocs in the View Docs tab. But when I go to download the document as an HTML or PDF, it shows me the Sphinx page that I have attached as a screenshot. I followed all the instructions in the document and I think I've done everything fine.

If I have the time, I will update your documentation (if open source) because there are big gaps in it in my opinion as a technical writer.

@raoshridhar90
Copy link
Author

I'm pretty certain this issue is because the documentation type is set to Sphinx instead of MkDocs. In the settings for your project, you need to change the documentation type.

screen shot 2018-10-16 at 11 23 26 am

Hey @davidfischer, I thought that was the problem too, the first time I encountered this. But in this current generation instance, it is Markdown as shown below.
readthedocs troubleshooting

@davidfischer
Copy link
Contributor

If I have the time, I will update your documentation (if open source) because there are big gaps in it in my opinion as a technical writer.

I wrote this relatively recently and would love help on filling in the gaps. It is open source and you can find the getting started with mkdocs guide here.

Hey @davidfischer, I thought that was the problem too, the first time I encountered this. But in this current generation instance, it is Markdown as shown below.

Actually when I look at this, I don't yet see what the problem is. Based on your repository, I think it should generate HTML like this. Maybe I don't yet fully understand the problem.

@stsewd
Copy link
Member

stsewd commented Oct 17, 2018

So, I think I understand the problem here, your project is mkdocs type, mkdocs doesn't support pdf or epub generation. But, I can see that your project does have links to download pdf and epub.

So, I saw your builds, and I found that one of those was using sphinx, there were generated pdf and epub files. Then, when building back with mkdocs, those files aren't removed, so your project keeps serving the old sphinx generated files.

We should clean that files when building with mkdocs.

@raoshridhar90
Copy link
Author

@stsewd thank you! How do I clean those files is my question.

@stsewd
Copy link
Member

stsewd commented Oct 17, 2018

I think a workaround can be building with sphinx again, but un-selecting the epub and pdf generation, then if you change back to mkdocs, those files should be removed. But this is a bug on rtd and we should fixed it

@stsewd stsewd added Bug A bug and removed Needed: more information A reply from issue author is required Support Support question labels Oct 17, 2018
@raoshridhar90
Copy link
Author

raoshridhar90 commented Oct 17, 2018 via email

@raoshridhar90
Copy link
Author

If I have the time, I will update your documentation (if open source) because there are big gaps in it in my opinion as a technical writer.

I wrote this relatively recently and would love help on filling in the gaps. It is open source and you can find the getting started with mkdocs guide here.

Hey @davidfischer, I thought that was the problem too, the first time I encountered this. But in this current generation instance, it is Markdown as shown below.

Actually when I look at this, I don't yet see what the problem is. Based on your repository, I think it should generate HTML like this. Maybe I don't yet fully understand the problem.

Hey @davidfischer, I will definitely do it when I figure out this problem. Also, I think there are gaps in the ReadTheDocs documentation. MkDocs seems pretty straightforward. However, for now, the link you attached seems to be broken, so I don't really know what you mean. Haha, wow. This is confusing.

@raoshridhar90
Copy link
Author

I think a workaround can be building with sphinx again, but un-selecting the epub and pdf generation, then if you change back to mkdocs, those files should be removed. But this is a bug on rtd and we should fixed it

@stsewd, I tried that but same problem again. Doesn't seem to be making a difference. I hope that bug is ironed out soon then!

@davidfischer
Copy link
Contributor

However, for now, the link you attached seems to be broken

That's weird. It seems to be working for me even in incognito!

I still don't seem to understand this issue. I don't see the links to download an epub or PDF anymore.

screen shot 2018-10-18 at 10 55 13 am

@stsewd
Copy link
Member

stsewd commented Oct 18, 2018

@davidfischer If I recall correctly, we don't generate any type of download for Mkdocs projects, the download section shouldn't be there.

@raoshridhar90 rtd built the html files for download on sphinx always, it can only be disabled using a configuration file https://docs.readthedocs.io/en/latest/yaml-config.html#supported-settings The pdf and epub aren't there, so the previous step worked! So, I see two workarounds here, using a config file to not build any format (and repeat the previous step of change the doctype to sphinx), or just recreating your project and using mkdocs as the doctype from the beginning

@raoshridhar90
Copy link
Author

However, for now, the link you attached seems to be broken

That's weird. It seems to be working for me even in incognito!

I still don't seem to understand this issue. I don't see the links to download an epub or PDF anymore.

screen shot 2018-10-18 at 10 55 13 am

@davidfischer, it's working fine now. Thanks! If @stsewd is saying it shouldn't be generating any download, then I don't know why this is. Any explanations, @stsewd? Also, I disabled epub and PDF, that's why you can't see anything.

@stsewd, I actually decided to check out Sphinx as my documentation base and it wasn't as hard as I thought. The only issue is that ReadTheDocs is not applying its own theme to the Sphinx created HTML. I'll have to play around with it, I guess? Well, the PDF and Epub aren't there because I disabled them but if you don't allow downloads in Markdown, then there's no point for me to use Markdown, right?

@stsewd
Copy link
Member

stsewd commented Oct 18, 2018

If @stsewd is saying it shouldn't be generating any download, then I don't know why this is. Any explanations, @stsewd?

Is because of the same problem, you built wih sphinx once, rtd generated the download files, then when changing to mkdocs, rtd doesn't clean the previous files.

  • We don't provide any downloads on Mkdocs (that's a limitation of mkdocs, not from rtd).
  • You can use markdown with sphinx (downloads here are supported)

@raoshridhar90
Copy link
Author

If @stsewd is saying it shouldn't be generating any download, then I don't know why this is. Any explanations, @stsewd?

Is because of the same problem, you built wih sphinx once, rtd generated the download files, then when changing to mkdocs, rtd doesn't clean the previous files.

  • We don't provide any downloads on Mkdocs (that's a limitation of mkdocs, not from rtd).
  • You can use markdown with sphinx (downloads here are supported)

Haha, cool. I'll play around with Sphinx a bit. Thank you so much for all the help. I hope you get that bug sorted out. Also, thank you so much; you guys are much friendlier and much more helpful than StackOverflow. Those dudes are rude!

@stsewd
Copy link
Member

stsewd commented Oct 22, 2018

@stsewd stsewd changed the title Mkdocs displaying on ReadTheDocs but Sphinx downloading as HTML Artifacts aren't cleaned when changing from Sphinx to Mkdocs Oct 25, 2018
@raoshridhar90
Copy link
Author

@stsewd, I migrated completely to Sphinx from Mkdocs, but thanks for all the help!

@stsewd stsewd added the Priority: low Low priority label Jan 3, 2019
@stale
Copy link

stale bot commented Feb 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Feb 17, 2019
@stsewd
Copy link
Member

stsewd commented Feb 17, 2019

Not stale, just low priority :) bot

@stsewd
Copy link
Member

stsewd commented Mar 28, 2019

I can't replicate this anymore locally or in production. It was fixed #4947 in with the delete_unsynced_media arg

@stsewd stsewd closed this as completed Mar 28, 2019
@jyearsley
Copy link

I'm having this same problem, that is, my them is Mkdocs, but the build is done by Sphinx even when I make the change in Advanced Settings

@humitos
Copy link
Member

humitos commented Mar 1, 2023

@jyearsley if you are using a configuration file (see https://docs.readthedocs.io/en/stable/config-file/v2.html), you should change this in that file. If that doesn't solve your immediate problem, please open a new issue filling the template with your projects' info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Priority: low Low priority
Projects
None yet
Development

No branches or pull requests

5 participants