Skip to content

Search code pagination is slow/broken #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericholscher opened this issue Sep 30, 2018 · 3 comments
Closed

Search code pagination is slow/broken #4687

ericholscher opened this issue Sep 30, 2018 · 3 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug
Milestone

Comments

@ericholscher
Copy link
Member

ericholscher commented Sep 30, 2018

The default count method on our ES "querysets" is really slow

We have worked around this by exploiting a behavior in Django that just calls len(queryset) when count() is invalid.

We should fix this in a better way, so this ticket exists to track that work.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Bug A bug Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@agjohnson agjohnson added this to the Refactoring milestone Feb 4, 2019
@stsewd
Copy link
Member

stsewd commented Mar 1, 2019

@ericholscher Is this still valid with the new search?

@ericholscher
Copy link
Member Author

Yea, I believe we removed the workaround. There is still another issue with counting in #5235, but we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

3 participants