-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Build - This page does not exist yet. #3303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is something that was changed recently at #3260. I think the that the decision is not to show the Build button in projects where you don't have permissions. I'm creating a PR for this behaviour. |
I like the button - it gives a hint that it is possible to rebuild docs online. |
I also liked the button, but it's true that it's kind of weird to trigger builds in documentation that are not your projects. I'm not sure if this could be a problem or not. Maybe @agjohnson can explain more about this decision. |
I don't see how manually triggering a build is a problem for projects that you don't own on RTD. As a contributor, I like to trigger builds regardless of my status with RTD. If there is abuse in the system, it should be proven that it actually takes place and throttled, like any sane API does. |
* Do not show Build button when user is not project admin Closes #3303 * Add test to check for Build section * Fix old test to make sure a public branch is listed
Details
Hitting the Build button for the above project gives this message:
I am logged in. If I am not logged in, RTD proposes to login.
Expected Result
Starting build, or explaining why it doesn't happen.
The text was updated successfully, but these errors were encountered: