Skip to content

Build passed but there is an error on the build page #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Nov 19, 2017 · 1 comment · Fixed by #3292
Closed

Build passed but there is an error on the build page #3285

humitos opened this issue Nov 19, 2017 · 1 comment · Fixed by #3292
Assignees
@humitos
Labels
Bug A bug Priority: high High priority
Milestone
Build stability

Comments

@humitos
Copy link
Member

humitos commented Nov 19, 2017

Details

Expected Result

Matching the build status with the message

Actual Result

It says the build Passed but it has Failed

captura de pantalla_2017-11-19_16-43-48

Related: #3284
@humitos humitos added this to the Build stability milestone Nov 19, 2017
@humitos humitos added the Bug A bug label Nov 19, 2017
@agjohnson
Copy link
Contributor

This might be related to #3280

@agjohnson agjohnson added the Priority: high High priority label Nov 20, 2017
humitos added a commit that referenced this issue Nov 21, 2017
@humitos
Update build from database at __exit__
0fa8241 
When an exception happens and it's handled by __exit__ our Build in
the database is not updated and it stay in 'Installing' forever. So,
when something bad happens we force a call to `update_build` with the
FINISHED state

Attempt to fix #3285
@humitos humitos mentioned this issue Nov 21, 2017
Merged
agjohnson pushed a commit that referenced this issue Nov 22, 2017
@humitos @agjohnson
Update build from database at __exit__ (#3292)
3e1651e 
* Update build from database at __exit__

When an exception happens and it's handled by __exit__ our Build in
the database is not updated and it stay in 'Installing' forever. So,
when something bad happens we force a call to `update_build` with the
FINISHED state

Attempt to fix #3285

* `update_build` when FINISHED in the right place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Bug A bug Priority: high High priority
Projects
None yet
Milestone
Build stability
Development

Successfully merging a pull request may close this issue.

Update build from database at __exit__ readthedocs/readthedocs.org
2 participants
@humitos @agjohnson