Skip to content

Make BUILD_IMAGES a setting instead of a constant #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Nov 13, 2017 · 0 comments
Closed

Make BUILD_IMAGES a setting instead of a constant #3254

humitos opened this issue Nov 13, 2017 · 0 comments
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Nov 13, 2017

At the moment BUILD_IMAGES (https://github.com/rtfd/readthedocs.org/blob/c7e4f538b4364964d1b694820e38de3b973a26a3/readthedocs/doc_builder/constants.py#L31) is a constant and since sometimes we need to use a custom docker image (as pointed in #2692) we need to modify it to set the new supported versions in the image.

In my case, I needed to add this key:

    'readthedocs/build:dev': {
        'python': {'supported_versions': [2, 2.7, 3, 3.5]},
    },

So, we need to check all the places where this constant is used and replace it for the new setting called DOCKER_BUILD_IMAGES plus add a default in the base.py setting file.

@agjohnson agjohnson added the Improvement Minor improvement to code label Nov 16, 2017
@humitos humitos added the Good First Issue Good for new contributors label Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants