Skip to content

Allow skipping submodule clone #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bendk opened this issue Oct 31, 2017 · 8 comments
Closed

Allow skipping submodule clone #3215

bendk opened this issue Oct 31, 2017 · 8 comments
Labels
Improvement Minor improvement to code

Comments

@bendk
Copy link

bendk commented Oct 31, 2017

Details

Expected Result

Documentation to build

Actual Result

The build process fails when checking out a submodule. That's because it's a optional private repository. It's not needed in general to run the app, and certainly not to build the documentation.

It would be great to have the option to skip submodule cloning for certain submodules, or altogether. This would allow our builds to work again.

@stsewd
Copy link
Member

stsewd commented Dec 27, 2017

I think this feature is on the plans readthedocs/readthedocs-build#30

@agjohnson
Copy link
Contributor

agjohnson commented Feb 16, 2018

For now, the most basic for of this change is to look for a .gitmodules and only conditionally run the submodule operations if we have submodules in the repository.

This would also address one of the issues in #3520, where i think we're going to have a lot of noisy commands that we can prune from the build output list.

Edit: oops, I read too quickly. If you have a .gitmodules the above change won't help.

@jerome-labbe-sb
Copy link

Hi, since the last update it's impossible for us to build our documentation anymore...
Just like OP, we need an option to skip submodules while having a .gitmodules file in our repo

@stsewd
Copy link
Member

stsewd commented Mar 1, 2018

@jerome-labbe-sb maybe your problem is related to #3707 (comment)? By @humitos I know the rtd team is working on solving that problem.

This was referenced Mar 1, 2018
@jerome-labbe-sb
Copy link

@stsewd unfortunately it doesn't seem to be related...

@humitos humitos assigned humitos and unassigned humitos Mar 2, 2018
@stsewd
Copy link
Member

stsewd commented Mar 2, 2018

@jerome-labbe-sb you can fill a new issue with more details about your problem, so we can help you.

@humitos
Copy link
Member

humitos commented Apr 30, 2018

@bendk Hi! We have a temporal flag to skip the checkout of all the submodules, so I added that flag to your amara project.

Later, when the PR pointed by @stsewd is merged, you will be able to configure it by yourself.

I'm closing this issue. Please, let me know if that fixes your problem or not.

@humitos humitos closed this as completed Apr 30, 2018
@bendk
Copy link
Author

bendk commented May 1, 2018

Looks good so far, my first build failed but it was unrelated to the submodules. Thanks for the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

6 participants