Skip to content

Support latest Pygments (for improved Haskell syntax, and more) #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
declension opened this issue Mar 12, 2017 · 2 comments
Closed

Support latest Pygments (for improved Haskell syntax, and more) #2720

declension opened this issue Mar 12, 2017 · 2 comments
Labels
Improvement Minor improvement to code

Comments

@declension
Copy link
Contributor

Change Requested

The use of Pygments==2.2.0 (or newer, potentially) to highlight code.

Background

As part of a syntax highlighting problem noted on Haskell-Servant, @teh pushed a PR for Pygments that was merged a while ago.

I've submitted a Pygments dependency bump in the Servant codebase which works locally, but as we use https://readthedocs.org for actually hosting, it won't help solve the real problem unless Pygments is upgraded here too...

declension added a commit to declension/readthedocs.org that referenced this issue Mar 12, 2017
@humitos
Copy link
Member

humitos commented Mar 13, 2017

Currently, RTD uses pygments==2.0.2. Not sure, but I think that upgrading it to 2.2.0 won't be a big deal. Anyway, in the meanwhile, you could use that particular version in your requirements.txt file for read the docs.

@humitos humitos added the Improvement Minor improvement to code label Mar 13, 2017
@declension
Copy link
Contributor Author

@humitos thanks - we have now actually, and it seems to be working well (see latest haskell-servant docs vs previous 0.10 version).

So I guess this is a lower priority for now but still might be nice to have (and FWIW I'll report back if I notice anything weird)

teh added a commit to haskell-graphql/graphql-api that referenced this issue Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants