Skip to content

Replace extension pattern with updated version #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agjohnson opened this issue Jan 27, 2017 · 2 comments
Closed

Replace extension pattern with updated version #2618

agjohnson opened this issue Jan 27, 2017 · 2 comments
Labels
Good First Issue Good for new contributors Sprintable Small enough to sprint on
Milestone
Cleanup

Comments

@agjohnson
Copy link
Contributor

We have two extension patterns utilized currently. These extension points are required so that we can add additional functionality or altered querysets on readthedocs.com.

The modern version is in readthedocs.core.utils.extend, and an example of this extension is readthedocs.core.symlink.PublicSymlink. There are a number of classes using arbitrary settings to allow for override in readthedocs.privacy.backend. Unifying these two implementations would clean things up and consolidate our settings.

Ref #2611
@agjohnson agjohnson added Good First Issue Good for new contributors Sprintable Small enough to sprint on labels Jan 27, 2017
@agjohnson agjohnson added this to the Cleanup milestone Jan 27, 2017
@agjohnson agjohnson mentioned this issue Jan 27, 2017
Merged
@rixx
Copy link
Contributor

rixx commented Mar 9, 2017

readthedocs.privacy.backend already uses SettingsOverrideObject with VersionManager/VersionQuerySet - what else do you see as requiring changes?

@agjohnson
Copy link
Contributor Author

The old pattern is used in these spots:

fmoor added a commit to fmoor/readthedocs.org that referenced this issue May 22, 2017
@fmoor
Replace extension pattern with updated version, resolves readthedocs#…
5b8cbc3 
…2618
@fmoor fmoor mentioned this issue May 22, 2017
Merged
agjohnson pushed a commit that referenced this issue May 22, 2017
@fmoor @agjohnson
Replace extension pattern with updated version, resolves #2618 (#2880)
f8f3aff
fmoor added a commit to fmoor/readthedocs.org that referenced this issue May 24, 2017
@fmoor
Replace extension pattern with updated version, resolves readthedocs#…
fd468a2 
…2618 (readthedocs#2880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Sprintable Small enough to sprint on
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
2 participants
@agjohnson @rixx