Skip to content

Project slug names that are not valid DNS names are not caught on project creation #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agjohnson opened this issue Jan 20, 2017 · 0 comments · Fixed by #3464
Closed

Project slug names that are not valid DNS names are not caught on project creation #2600

agjohnson opened this issue Jan 20, 2017 · 0 comments · Fixed by #3464
Labels
Bug A bug
Milestone
Admin UX

Comments

@agjohnson
Copy link
Contributor

A sufficiently long enough project name will still be linked from RTD, but the DNS lookup will fail viewing these docs. We should be double checking for slugs that would be 63 characters or more and failing validation.
@agjohnson agjohnson added the Bug A bug label Jan 20, 2017
@agjohnson agjohnson added this to the Admin UX milestone Nov 16, 2017
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Dec 29, 2017
@stsewd
Set slug max length to 63
36a6f1c 
A valid DNS label can contain up to 63 characters

Closes readthedocs#2600
@stsewd stsewd mentioned this issue Dec 29, 2017
Merged
stsewd added a commit to stsewd/readthedocs.org that referenced this issue Nov 2, 2018
@stsewd
Set slug max length to 63
dac8276 
A valid DNS label can contain up to 63 characters

Closes readthedocs#2600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug
Projects
None yet
Milestone
Admin UX
Development

Successfully merging a pull request may close this issue.

Make slug field a valid DNS label stsewd/readthedocs.org
1 participant
@agjohnson