Skip to content

Celery is a rather bad subproject example #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
virtuald opened this issue Jan 14, 2017 · 8 comments
Closed

Celery is a rather bad subproject example #2588

virtuald opened this issue Jan 14, 2017 · 8 comments
Labels
Improvement Minor improvement to code

Comments

@virtuald
Copy link
Contributor

This has been bothering me for a few years now, but in the FAQ it calls out the celery/kombu projects as an example of subprojects. I suppose it's technically true, they are related projects, and they do use the subprojects functionality of RTD. But if you didn't know that kombu existed, you'd never be able to find it from the celery project.

I'd been contemplating using subprojects for awhile now, and my RobotPy project really suffered from the problem of having disconnected documentation sites... so last month I sat down and did some thinking, and I think I came up with a great solution that resulted in a unified set of subprojects that all mostly feel like they're the same site because they share the same sidebar/theme (and because of #1866, the search works across them all too! thanks!). Check it out:

I also wrote a blog post on how I went about it, that could be useful to link to in the FAQ (or at least borrow the information/technique).

It would be good for others to have information on how to better use this useful feature. I can PR an edit to the FAQ if you aren't opposed to it -- if there are other/better/bigger examples to cite, that would be fine also.

@ericholscher
Copy link
Member

This is a great idea. I agree that Celery isn't the best example, but there hasn't been a huge number of projects that would be good examples. Thanks for writing up all this stuff -- if you want to send over a docs patch, I'd love to include all the great work you're done!

@ericholscher
Copy link
Member

We've also been thinking on some things that would let us integrate the menu TOC's and other bits from across subprojects -- so I'll definitely make sure to loop you in when we start working on that stuff.

@virtuald
Copy link
Contributor Author

Cool, I'll try to find some time to put it together next week.

@ericholscher
Copy link
Member

Would love to get this out, if you find time! 👍

@virtuald
Copy link
Contributor Author

virtuald commented Feb 7, 2017

It is still on my calendar to do it, I just keep hitting 'delay 1 day'. :)

My work with FIRST Robotics keeps me super super busy until the end of February, but I will find time to do it.

@humitos humitos added the Improvement Minor improvement to code label Feb 23, 2017
@ericholscher
Copy link
Member

🔘 Delay Thirty Days

😁

@virtuald
Copy link
Contributor Author

virtuald commented Mar 9, 2017

It'll happen soon... 📆

virtuald added a commit to virtuald/readthedocs.org that referenced this issue Apr 10, 2017
virtuald added a commit to virtuald/readthedocs.org that referenced this issue Apr 18, 2017
virtuald added a commit to virtuald/readthedocs.org that referenced this issue Apr 18, 2017
@agjohnson
Copy link
Contributor

Closing this due to inactivity. While the relationship between Celery and Kombu aren't obvious, it does at least illustrate our subproject feature. So, this change isn't entirely necessary unless someone wants to take this work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants