Search option is case sensitive(?)

[pieterlukasse]

Details

• Project URL: http://cbioportal-inodb.readthedocs.io/en/latest/

Expected Result

I would like the search to be case insensitive.

Actual Result

When using the search option, I noticed that it only finds results when the case is matching. This should not be the case. Example: searching for cbioportalImporter.py or cbioportalimporter.py in the documentation URL above gives different results (in this case only the first one results in matches).

[smrgit]

I have also experienced this -- is there a way to make searches case-insensitive? or are there any options for how the search is performed?

[pieterlukasse]

I have not found one. I hope the developers here can give this some priority...

[smrgit]

@pieterlukasse within the past couple of days things seem to have changed -- can you confirm that the search now seems to be case-insensitive? (or could it be a browser issue in some strange way?) another thing I'm noticing it is that partial-word searching doesn't work which was my attempted-work-around to avoid having to choose whether the first letter was upper- or lower-case ...

[pieterlukasse]

@smrgit no, searching for cbioportalimporter.py in referred documentation still gives no results. When I use only cbioportalimporter, then I get some results (also in different case). So maybe it is improved a bit...but not quite there yet.

[safwanrahman]

@ericholscher If anyone wants to have a case sensitive search, what they will need to do then?

[ericholscher]

I don't know if we need to support case sensitive, but perhaps we could support it with quotes. ""importedFile" for example.

[ericholscher]

@safwanrahman would be good to add some tests to confirm this, and then we can call it done, and will catch any regressions if they happen.

[ericholscher]

So:

• The default search should always return things in any case (case insensitive)

We need to decide if we want to support the ability to search case sensitive, and how it would work. One idea would be to quote things "ImportedFile" -- but I worry, as it would also make "run the tests" not return results for Run the tests. So we should think more about how to implement case sensitivity, and perhaps choose not to implement it at all.

[ericholscher]

This has been fixed in our new search code. It will be deployed in the next month or so, so closing this issue as it's been addressed.

[safwanrahman]

I am reopening this issue because I believe there should be case sensitive search also.
While I search in RTD, sometimes I would like to search for a specific class like Foo. Currently, it gives me proper result. but after my fix has been deployed, It will return all the result where there are foo, Foo, FOO, fOO, fOo etc. So it will really break the search experience of many of the user.
I think a design decission is needed.
We can give Case Sensitive match more wight, and insensitive match lower weight. So both type of result comes to the search result, but Case Sensitive gets higher priority.
What do you think @ericholscher @agjohnson @davidfischer