Skip to content

Project import doesn't open import form with FF on OSX #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hackebrot opened this issue Oct 19, 2015 · 10 comments
Closed

Project import doesn't open import form with FF on OSX #1773

hackebrot opened this issue Oct 19, 2015 · 10 comments
Assignees
@agjohnson
Labels
Bug A bug

Comments

@hackebrot
Copy link

Hi there!

I am trying to import a new project to rtfd at Import a Repository. For some reason pressing named button doesn't seem to do anything. I am not getting any errors or success messages.

This would be the project I'd like to import https://github.com/hackebrot/pytest-cookies and my account is hackebrot. Any help is greatly appreciated. 🙇

Thank your for your great work! I ❤️ readthedocs
@agjohnson
Copy link
Contributor

Which button are you referring to? If it's what I think it is, the old javascript and css might be cached still, and just requires a refresh. If that's not it, are you receiving any javascript errors on your console when clicking the import button?

@agjohnson agjohnson added the Support Support question label Oct 19, 2015
@hackebrot
Copy link
Author

Talking about the + button on the very right.

screen shot 2015-10-19 at 23 07 10

Refreshing didn't seem to help and the javascript console doesn't report any errors apparently.

screen shot 2015-10-19 at 23 14 13

@agjohnson
Copy link
Contributor

Ah okay, that wasn't what I thought it was then. This looks like Firefox on OSX, I've confirmed the same behavior there. This looks like a bug with the JS that submits the form.

@agjohnson agjohnson changed the title Problem with *import* button Project import doesn't open import form with FF on OSX Oct 19, 2015
@agjohnson agjohnson added Bug A bug and removed Support Support question labels Oct 19, 2015
@hackebrot
Copy link
Author

Yeah sorry about missing out my specs. OS X 10.10.5 Firefox 41.0.2 😶

@hackebrot
Copy link
Author

Works just fine on Safari 9.0

@agronholm
Copy link
Contributor

Firefox 42 on Ubuntu 15.10. No errors in console but pressing the button does nothing.

@agjohnson agjohnson mentioned this issue Jan 6, 2016
Closed
@str4d
Copy link

str4d commented Jun 19, 2016

Same issue with FIrefox 47 on WIndows 7.

@str4d
Copy link

str4d commented Jun 19, 2016

Works fine on Chrome 51.0.2704.103 m on the same Windows 7 machine.

@waveform80
Copy link

Same issue with Firefox 48 on Ubuntu 16.04 (no errors in console, the javascript event seems to be in place, but clicking the button does nothing); seems happy under Chrome 52 on the same platform.

@agjohnson agjohnson mentioned this issue Nov 1, 2016
Closed
agjohnson added a commit that referenced this issue Nov 1, 2016
@agjohnson
Fix Firefox import project bug
575f0f1 
Firefox is particular about how a form element can submit. It requires the form
to have a button and to be added to the body of the document.

Fixes #1773
@agjohnson agjohnson mentioned this issue Nov 1, 2016
Merged
@agjohnson agjohnson self-assigned this Nov 1, 2016
ericholscher pushed a commit that referenced this issue Nov 1, 2016
@agjohnson @ericholscher
Fix Firefox import project bug (#2484)
65a522d 
Firefox is particular about how a form element can submit. It requires the form
to have a button and to be added to the body of the document.

Fixes #1773
@hackebrot
Copy link
Author

Thank you for fixing this! 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agjohnson agjohnson

Labels
Bug A bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ericholscher @agronholm @waveform80 @agjohnson @str4d @hackebrot