-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
rtd theme shows expand bullets on local instance, but not readthedocs.org #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The reason for this is, that the live version doesn't load the full TOC into the sidebar. I'm not 100% sure why this is the case, but I assume it's to save on loadtime as the TOC can get really huge if you create lots of subheaders. @ericholscher @agjohnson maybe you can shed some light on this and you might already have a plan in mind on how to fix this? |
There is a theme option |
So I tried setting that theme option: https://github.com/hach-que/Protogame.Docs/blob/master/conf.py#L115, but it didn't make the bullet points show up: https://protogame.readthedocs.org/en/latest/index.html |
@hach-que that happens because of how we have to bend Sphinx in order to use the sphinx_rtd_theme instead of default. In your case we override the You can see the code that modifies your settings here: https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl#L62
That should trick our checks for the default theme and allow you to define |
You can now examine the generated |
- Trying to follow this readthedocs/readthedocs.org#1622 (comment) - and actual con.py blob appended by RTD: using_rtd_theme = ( ( 'html_theme' in globals() and html_theme in ['default'] and # Allow people to bail with a hack of having an html_style 'html_style' not in globals() ) or 'html_theme' not in globals() ) if using_rtd_theme: theme = importlib.import_module('sphinx_rtd_theme') html_theme = 'sphinx_rtd_theme' html_style = None html_theme_options = {} if 'html_theme_path' in globals(): html_theme_path.append(theme.get_html_theme_path()) else: html_theme_path = [theme.get_html_theme_path()]
- Trying to follow this readthedocs/readthedocs.org#1622 (comment) - and tricked actual con.py blob appended by RTD: using_rtd_theme = ( ( 'html_theme' in globals() and html_theme in ['default'] and # Allow people to bail with a hack of having an html_style 'html_style' not in globals() ) or 'html_theme' not in globals() ) if using_rtd_theme: theme = importlib.import_module('sphinx_rtd_theme') html_theme = 'sphinx_rtd_theme' html_style = None html_theme_options = {} if 'html_theme_path' in globals(): html_theme_path.append(theme.get_html_theme_path()) else: html_theme_path = [theme.get_html_theme_path()]
- Trying to follow this readthedocs/readthedocs.org#1622 (comment) - and tricked actual con.py blob appended by RTD: using_rtd_theme = ( ( 'html_theme' in globals() and html_theme in ['default'] and # Allow people to bail with a hack of having an html_style 'html_style' not in globals() ) or 'html_theme' not in globals() ) if using_rtd_theme: theme = importlib.import_module('sphinx_rtd_theme') html_theme = 'sphinx_rtd_theme' html_style = None html_theme_options = {} if 'html_theme_path' in globals(): html_theme_path.append(theme.get_html_theme_path()) else: html_theme_path = [theme.get_html_theme_path()]
Locally:
On readthedocs.org:
Note the lack of the "[+]" icon on readthedocs.org. This icon is valuable to indicate what items have additional content underneath them (as opposed to being a single page).
This can be seen at https://protogame.readthedocs.org/en/latest/assets/index.html.
The text was updated successfully, but these errors were encountered: