Skip to content

Uninformative error when branch name contains a dot #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
takluyver opened this issue Aug 11, 2015 · 6 comments
Closed

Uninformative error when branch name contains a dot #1553

takluyver opened this issue Aug 11, 2015 · 6 comments
Labels
Bug A bug

Comments

@takluyver
Copy link
Contributor

We were just experimenting with some docs stuff, and @minrk created a branch name with a dot (.) in it. Builds on this branch all failed, and the only error message in the logs was "top level build failure". It took us a while to work out that the branch name was the problem.

I don't think it's especially important to allow branch names with dots, but it would be nice to at least get an error that pointed us to the branch name.
@agjohnson agjohnson added the Bug A bug label Aug 12, 2015
@agjohnson
Copy link
Contributor

Agreed, this could be an edge case bug that wasn't covered with some changes to branch name slugging.

@gregmuellegger
Copy link
Contributor

Hm, I tried locally with the pypy project and built their release-2.6.x branch which worked.
@takluyver could you provide us with the branch you have problems with?

@gregmuellegger gregmuellegger added the Needed: more information A reply from issue author is required label Aug 17, 2015
@takluyver
Copy link
Contributor Author

I think it was a docs project @minrk had set up with his fork of the ipython/ipython GH repo to experiment. He might have more details.

@minrk
Copy link
Contributor

minrk commented Aug 17, 2015

The branch name was 'conf.py-hacks' Pushing the same commit to a new branch 'target' resulted in a successful build.

@sih4sing5hong5 sih4sing5hong5 mentioned this issue Aug 25, 2015
Closed
gregmuellegger added a commit that referenced this issue Sep 7, 2015
@gregmuellegger
Fix logic in Project.conf_dir
7aca48e 
The original implementation replaced "/conf.py" with an empty string, where it
only wanted to return the directory name of the conf.py file. This resulted in
problems when "/conf.py" was part of the directory name!

Fixes #1553.
@gregmuellegger gregmuellegger mentioned this issue Sep 7, 2015
Merged
@gregmuellegger
Copy link
Contributor

I investigated on this and found that the problem is not related to the dot in the branch name but the substring conf.py. I proposed a fix in #1629.

@gregmuellegger gregmuellegger removed the Needed: more information A reply from issue author is required label Sep 7, 2015
@minrk
Copy link
Contributor

minrk commented Sep 7, 2015

Thanks, @gregmuellegger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gregmuellegger @minrk @takluyver @agjohnson