Skip to content

wrong link for "Edit on GitHub" of README.rst (if index.rst does not exist) #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wdv4758h opened this issue Aug 9, 2015 · 3 comments · Fixed by #1597
Closed

wrong link for "Edit on GitHub" of README.rst (if index.rst does not exist) #1550

wdv4758h opened this issue Aug 9, 2015 · 3 comments · Fixed by #1597
Labels
Bug A bug

Comments

@wdv4758h
Copy link

wdv4758h commented Aug 9, 2015

Currently, doc_builder/base.py will rename README.rst to index.rst if repo does not have index.rst. And this make the generated index.html finding index.rst as source. Then, it cause 404 when user click "Edit on GitHub". (repo only have README.rst)

@gregmuellegger gregmuellegger added the Bug A bug label Aug 20, 2015
@gregmuellegger
Copy link
Contributor

@ericholscher
Copy link
Member

I believe our servers will now serve README.html as an index file, so we can probably stop transforming the files and be good.

@gregmuellegger
Copy link
Contributor

@ericholscher I tried this in #1585, but it seems to be more complicated. See there for comments.

ericholscher added a commit that referenced this issue Aug 26, 2015
Only support index.[md,rst] for the index.

This fixes #1550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants