Skip to content

MkDocs theme integration broken by a recent change #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d0ugal opened this issue Aug 5, 2015 · 5 comments · Fixed by #1545
Closed

MkDocs theme integration broken by a recent change #1542

d0ugal opened this issue Aug 5, 2015 · 5 comments · Fixed by #1545
Assignees
@gregmuellegger
Labels
Bug A bug

Comments

@d0ugal
Copy link
Contributor

d0ugal commented Aug 5, 2015

The popup thing used to be docked in the left side, now it off floating on the right again.
@d0ugal d0ugal added Bug A bug Mkdocs labels Aug 5, 2015
@d0ugal
Copy link
Contributor Author

d0ugal commented Aug 5, 2015

See for example here: http://mkdocs.readthedocs.org/en/latest/

(I had somebody else test it, and it worked as first due to caches, so make sure you hard refresh)

@gregmuellegger
Copy link
Contributor

@d0ugal can you remember when it last worked?

@d0ugal
Copy link
Contributor Author

d0ugal commented Aug 6, 2015

I'd guess it worked around a week ago and perhaps more recently too.

gregmuellegger added a commit that referenced this issue Aug 6, 2015
@gregmuellegger
Fix sphinx_rtd_theme theme override in embed js
13c53c4 
The last refactor wasn't aware of the fact that the js Build class was
modifying the actual config object in place. We are fixing this by using a
getter method were the value is needed and are not mutating the original config
object in place.

Fixes #1542.
@gregmuellegger gregmuellegger mentioned this issue Aug 6, 2015
Merged
@gregmuellegger
Copy link
Contributor

Ok, found the problem. The JS refactor in #1463 did the harm (I'm responsible on that 😢)
Will be fixed with the merge of #1545

@d0ugal
Copy link
Contributor Author

d0ugal commented Aug 6, 2015

Awesome, thanks! It's good to see that refactor, the code was somewhat hacky to make it work with a Sphinx documentation. Good work :)

@gregmuellegger gregmuellegger self-assigned this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregmuellegger gregmuellegger

Labels
Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sphinx_rtd_theme theme override in embed js readthedocs/readthedocs.org
2 participants
@d0ugal @gregmuellegger